Skip to content

Conversation

@bobbylight
Copy link
Owner

@bobbylight bobbylight commented Feb 20, 2022

… line height configurable when word wrap is NOT enabled. Line number list is also updated.

Fold indicators do not currently work properly - they only update in the demo app because I've tied '8' and '9' keypresses to tweaking the line height for quick testing.

I think what still needs to be done is:

  • fold indicator immediate updating
  • fold indicator rendering of 'active' fold line
  • "classic" style of fold indicators doesn't render the "region" line indicator completely
  • and everything when word wrap is enabled

@bobbylight bobbylight linked an issue Feb 20, 2022 that may be closed by this pull request
@bobbylight bobbylight self-assigned this Feb 20, 2022
@bobbylight bobbylight force-pushed the fix-160-configurable-line-height branch 2 times, most recently from aff062a to 9191bf4 Compare November 23, 2024 20:47
@codecov
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

❌ Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.52%. Comparing base (ebb8826) to head (fb0f9d0).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...main/java/org/fife/ui/rtextarea/RTextAreaBase.java 25.00% 9 Missing ⚠️
...main/java/org/fife/ui/rtextarea/FoldIndicator.java 50.00% 1 Missing ⚠️
...ea/src/main/java/org/fife/ui/rtextarea/Gutter.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #433      +/-   ##
============================================
- Coverage     80.54%   80.52%   -0.03%     
- Complexity     7811     7812       +1     
============================================
  Files           179      179              
  Lines         30242    30256      +14     
  Branches       3905     3907       +2     
============================================
+ Hits          24359    24364       +5     
- Misses         4218     4225       +7     
- Partials       1665     1667       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bobbylight bobbylight force-pushed the fix-160-configurable-line-height branch from 9191bf4 to fa2e6f7 Compare November 30, 2024 14:02
@bobbylight bobbylight force-pushed the fix-160-configurable-line-height branch from fa2e6f7 to 04b4524 Compare December 8, 2024 20:03
@bobbylight bobbylight force-pushed the fix-160-configurable-line-height branch from 04b4524 to fb0f9d0 Compare February 17, 2025 19:49
… line height configurable when word wrap is NOT enabled. Line number list is also updated. Fold indicators do not currently work properly - they only update in the demo app because I've tied '8' and '9' keypresses to tweaking the line height for quick testing. I think what still needs to be done is: fold indicator immediate updating, fold indicator rendering of 'active' fold line, and *everything* when word wrap is enabled
@bobbylight bobbylight force-pushed the fix-160-configurable-line-height branch from fb0f9d0 to 15673f9 Compare December 30, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

configurable line height

2 participants