-
Notifications
You must be signed in to change notification settings - Fork 3
Adding defog Academic database for testing #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
john-sanchez31
wants to merge
23
commits into
main
Choose a base branch
from
John/acaddb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 21 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
06057fc
derm treatment basic1
john-sanchez31 1fd4be7
derm treatment basic questions
john-sanchez31 170246b
defog dermtreatments adv questions
john-sanchez31 4564b1a
Merge branch 'main' into John/defogdbs
john-sanchez31 4270099
dermtreatment adv added
john-sanchez31 cedb935
defog dermtreatment adv questions and mysql defog tests
john-sanchez31 ba497ba
dermtreatments gen questions
john-sanchez31 c11a1ce
dermtreatments gen sql files
john-sanchez31 ffe50a4
defog academic db init
john-sanchez31 d4a592a
Merge branch 'main' into John/acaddb
john-sanchez31 b6eb2d4
conflicts with main solved
john-sanchez31 68aab6c
init data postgres and sf, metadata added
john-sanchez31 3057d52
adding pydough functions, fixing metadata
john-sanchez31 92ad7d3
WIP: academic metadata naming and descriptions
john-sanchez31 68228da
academic metadata
john-sanchez31 8fd10b1
metadata fixed and WIP gen1 pydough
john-sanchez31 690b662
WIP 12 gen questions
john-sanchez31 ddc3cfd
Merge branch 'main' into John/acaddb
john-sanchez31 4078f93
gen test 13-20
john-sanchez31 70bb6f4
Merge branch 'main' into John/acaddb
john-sanchez31 831c1bc
mysql and sf e2e test added
john-sanchez31 ec9106d
minor fixes
john-sanchez31 28e4857
Merge branch 'main' into John/acaddb [run all]
john-sanchez31 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern with this format (all defog tables in the same schema:
main
) is that we could have name conflicts if any table has the same name. These tables should be in a different schemaACADEMIC
, the same administrative order we use in snowflake. The same can be done for SQLite using ATTACH. Probably also for MySQL using schemas.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that is the case, we don't really need 4 different metadata files if the types used are compatible with the metadata type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is copying how things are done for the real defog benchmark. We can change things potentially, but for now let's keep it consistent.