Add masked table column literal comperison masking rewrite #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… implemented [RUN CI]
knassre-bodo
commented
Sep 9, 2025
Comment on lines
+310
to
+311
| # If the literal is a list or tuple, convert each element | ||
| # individually and create an array literal. |
There was a problem hiding this comment.
This is needed because now, with the recent changes, a "list literal" can contain non-literal expressions, e.g. a list of function calls [MASK("foo"), MASK("bar")]
…/masked_relational_rewrite
knassre-bodo
commented
Sep 30, 2025
| "server masked": true, | ||
| "unprotect protocol": "PTY_UNPROTECT({}, 'deName')", | ||
| "protect protocol": "PTY_PROTECT({}, 'deName)", | ||
| "protect protocol": "PTY_PROTECT({}, 'deName')", |
There was a problem hiding this comment.
Missed earlier, cuases a bug in this PR because protect protocol isn't actually used until now.
knassre-bodo
requested review from
a team,
hadia206,
john-sanchez31 and
juankx-bodo
and removed request for
a team
hadia206
reviewed
Oct 2, 2025
| - `UNMASK(x) IN (literal1, ..., literalN)` -> `x IN (MASK(literal1), ..., MASK(literalN))` | ||
| """ | ||
|
|
||
| def protect_literal_comparison( |
There was a problem hiding this comment.
For consistency, the name should be rewrite_masked_literal_comparison
Comment on lines
+21
to
+25
| - `UNMASK(x) == literal` -> `x == MASK(literal)` | ||
| - `literal == UNMASK(x)` -> `MASK(literal) == x` | ||
| - `UNMASK(x) != literal` -> `x != MASK(literal)` | ||
| - `literal != UNMASK(x)` -> `MASK(literal) != x` | ||
| - `UNMASK(x) IN (literal1, ..., literalN)` -> `x IN (MASK(literal1), ..., MASK(literalN))` |
There was a problem hiding this comment.
Questions:
1- What would happen if the literal value is None ?
2- Is it possible to have nested calls? UNMASK(UNMASK(x)) == literal. If yes, then how would that be handled?
3- Why only equality/inequality? What about other comparison operations (>, >=, <, <=)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #417, performs the following rewrites on relational algebra expressions involving UNMASK operations:
UNMASK(expr) == literal->expr == MASK(literal)UNMASK(expr) != literal->expr != MASK(literal)ISIN(UNMASK(expr), [literal1, literal2, ...])->ISIN(expr, [MASK(literal1), MASK(literal2), ...])These rewrites are done through an additional shuttle run during relational simplification, which is only activated if the environment variable
PYDOUGH_ENABLE_MASK_REWRITESis set to 1.