Add a session keyword argument to to_sql and to_df
#427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… graph/config with the session in most places
knassre-bodo
requested review from
a team,
hadia206,
john-sanchez31 and
juankx-bodo
and removed request for
a team
knassre-bodo
commented
Sep 16, 2025
| @pytest.fixture(scope="module") | ||
| def sqlglot_relational_visitor() -> SQLGlotRelationalVisitor: | ||
| config: PyDoughConfigs = PyDoughConfigs() | ||
| return SQLGlotRelationalVisitor(DatabaseDialect.SQLITE, config) | ||
| @pytest.fixture | ||
| def sqlglot_relational_visitor(empty_sqlite_tpch_session) -> SQLGlotRelationalVisitor: | ||
| return SQLGlotRelationalVisitor(empty_sqlite_tpch_session) |
There was a problem hiding this comment.
Can no longer be module-level since we depend on empty_sqlite_tpch_session
juankx-bodo
approved these changes
Sep 17, 2025
| raise PyDoughSessionException( | ||
| f"Expected `session` to be a PyDoughSession, got {session.__class__.__name__}." | ||
| ) | ||
| if session.metadata is None: |
There was a problem hiding this comment.
We are only checking for metadata. Should we check also for session.config and session.database?
Could we build new_session from session in kwargs if it exists, then if metadata, config or database are provided we overwrite them in new_session and finally if any of them is null in new_session then we set that value with its value in active_session.
| @@ -1317,6 +1318,7 @@ def test_unqualified_node_exploration( | |||
| ], | |||
| verbose: bool, | |||
| get_sample_graph: graph_fetcher, | |||
There was a problem hiding this comment.
Should we provide the graph as part of the session?
john-sanchez31
approved these changes
Sep 17, 2025
| FROM main.customer AS customer | ||
| JOIN _s1 AS _s1 | ||
| ON _s1.o_custkey = customer.c_custkey | ||
| ORDER BY | ||
| total DESC | ||
| 3 DESC |
There was a problem hiding this comment.
Why did these queries change?
| @@ -1022,7 +1006,8 @@ The `explain` API is limited in that it can only be called on complete PyDough c | |||
|
|
|||
| To handle cases where you need to learn about a term within a collection, you can use the `explain_term` API. The first argument to `explain_term` is PyDough code for a collection, which can have `explain` called on it, and the second is PyDough code for a term that can be evaluated within the context of that collection (e.g. a scalar term of the collection, or one of its sub-collections). | |||
|
|
|||
| The `explain_term` API also has a `verbose` keyword argument (default False) to specify whether to include a more detailed explanation, as opposed to a more compact summary. | |||
| The `explain_term` API also has a `verbose` keyword argument (default False) to specify whether to include a more detailed explanation, as opposed to a more compact summary. The `explain_term` API also has an optional `verbose` argument (default=False) that enables displaying additional information. It also has an optional `session` argument to specify what configs etc. to use when explaining certain terms (if not provided, uses `pydough.active_session`). | |||
There was a problem hiding this comment.
Lets rephrase this so we don't use also has an optional argument twice.
Suggested change
| The `explain_term` API also has a `verbose` keyword argument (default False) to specify whether to include a more detailed explanation, as opposed to a more compact summary. The `explain_term` API also has an optional `verbose` argument (default=False) that enables displaying additional information. It also has an optional `session` argument to specify what configs etc. to use when explaining certain terms (if not provided, uses `pydough.active_session`). | |
| The `explain_term` API also has a `verbose` keyword argument (default False) to specify whether to include a more detailed explanation, as opposed to a more compact summary. The `explain_term` API also has some optional arguments. The `verbose` argument (default=False) that enables displaying additional information and the `session` argument to specify what configs etc. to use when explaining certain terms (if not provided, uses `pydough.active_session`). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #421.