Add ISO15693Error exception for ISO 15693 error responses#15
Merged
bofh69 merged 2 commits intoadd-better-iso15639-supportfrom Jan 5, 2026
Merged
Add ISO15693Error exception for ISO 15693 error responses#15bofh69 merged 2 commits intoadd-better-iso15639-supportfrom
bofh69 merged 2 commits intoadd-better-iso15639-supportfrom
Conversation
Merged
Co-authored-by: bofh69 <1444315+bofh69@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on ISO 15693 commands implementation
Add ISO15693Error exception for ISO 15693 error responses
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on #14 regarding incomplete error handling for ISO 15693 commands. The TODO comment indicated that error responses should use a dedicated exception type instead of the generic
PN5180Error.Changes
Added
ISO15693Errorexception class toconstants.pythat captures:Updated
send_and_receive_15693to raiseISO15693Errorinstead ofPN5180Errorwhen tags return error responsesExported
ISO15693Errorfrom package root for public APIUsage
Users can now catch ISO 15693-specific errors separately from general PN5180 communication failures and access the complete error response data.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.