Skip to content

Add bumpver and fix pypi publish#26

Merged
bofh69 merged 4 commits intomainfrom
fix-pypi-publish
Jan 11, 2026
Merged

Add bumpver and fix pypi publish#26
bofh69 merged 4 commits intomainfrom
fix-pypi-publish

Conversation

@bofh69
Copy link
Owner

@bofh69 bofh69 commented Jan 11, 2026

bumpver is now used to update the versions and tag a new release, using semantic versioning formatted tags in the future.

README.md's links are updated by the workflow job before building to link to github's tag tree for the new tag.

@bofh69 bofh69 requested a review from Copilot January 11, 2026 09:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces bumpver for semantic versioning and automated version management, while fixing PyPI publishing workflows. The changes move from manual version updates to a tool-based approach and update package metadata to improve compliance with Python packaging standards.

Changes:

  • Configured bumpver for automated version management with semantic versioning
  • Updated package metadata in pyproject.toml to use string-based license format and include additional license files
  • Modified GitHub Actions workflow to update README links before building packages
  • Removed the README from the package source (keeping only the root README)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/pn5180_tagomatic/README.md Removed package-level README, consolidating documentation to root
pyproject.toml Added bumpver configuration, updated license format, reordered dev dependencies, and configured version file patterns
MANIFEST.in Updated to include REUSE.toml and tests directory while removing .ino files and .reuse/dep5
.github/workflows/publish.yml Removed manual version update logic and added README link updating step

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +62 to +63
BASE_URL = "https://github.com/bofh69/PN5180-tagomatic/tree/$VERSION"
sed -i "s#](\\([^h]\\)#$BASE_URL/\\1#" README.md
Copy link

Copilot AI Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sed command references $BASE_URL but it won't be expanded correctly due to the assignment error on the previous line. Additionally, the regex pattern appears to be attempting to match markdown links but may not work as intended. The pattern should likely be s#](\\([^h][^)]*\\))#]($BASE_URL/\\1)#g to properly match relative links and avoid matching links that start with 'h' (like http/https).

Suggested change
BASE_URL = "https://github.com/bofh69/PN5180-tagomatic/tree/$VERSION"
sed -i "s#](\\([^h]\\)#$BASE_URL/\\1#" README.md
BASE_URL="https://github.com/bofh69/PN5180-tagomatic/tree/$VERSION"
sed -i 's#](\([^h][^)]*\))#]('"$BASE_URL"'/\1)#g' README.md

Copilot uses AI. Check for mistakes.
@bofh69 bofh69 merged commit 654050b into main Jan 11, 2026
21 checks passed
@bofh69 bofh69 deleted the fix-pypi-publish branch January 11, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants