Conversation
bofh69
force-pushed
the
fix-get-system-info
branch
from
c7c0554 to
288fa16
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the ISO15693 system information parsing and adds NDEF (NFC Data Exchange Format) parsing capabilities for both ISO14443a and ISO15693 cards.
Changes:
- Corrected the system information parsing in ISO15693 by adjusting byte offsets and improving error handling
- Added NDEF parsing methods (
decode_ccandget_ndef) to both ISO14443a and ISO15693 card classes - Updated example scripts to demonstrate NDEF reading functionality
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pn5180_tagomatic/session.py | Removed unnecessary parentheses in tuple unpacking |
| src/pn5180_tagomatic/iso15693.py | Fixed system info parsing offsets and added NDEF parsing methods |
| src/pn5180_tagomatic/iso14443a.py | Added NDEF parsing methods for ISO14443a cards |
| src/pn5180_tagomatic/cards.py | Added abstract method signature for get_ndef |
| examples/iso_15693-read-memory.py | Added NDEF extraction and display to example |
| examples/iso_14443-read-memory.py | Added NDEF extraction and display to example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bofh69
force-pushed
the
fix-get-system-info
branch
from
288fa16 to
f27132e
Compare
Also fix formatting for black-26.1.0
bofh69
force-pushed
the
fix-get-system-info
branch
from
f27132e to
8bf84bb
Compare
Owner
Author
|
@copilot Add tests for the decode_cc and get_ndef methods. |
12 tasks
Contributor
* Initial plan * Add comprehensive tests for decode_cc and get_ndef methods Co-authored-by: bofh69 <1444315+bofh69@users.noreply.github.com> * Refactor tests to use pytest fixtures Co-authored-by: bofh69 <1444315+bofh69@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bofh69 <1444315+bofh69@users.noreply.github.com>
bofh69
force-pushed
the
fix-get-system-info
branch
from
15867c5 to
7d25bc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.