Merged
Conversation
Also fix formatting for black-26.1.0
* Initial plan * Add comprehensive tests for decode_cc and get_ndef methods Co-authored-by: bofh69 <1444315+bofh69@users.noreply.github.com> * Refactor tests to use pytest fixtures Co-authored-by: bofh69 <1444315+bofh69@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bofh69 <1444315+bofh69@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the get_system_information method for ISO15693 cards and adds NDEF (NFC Data Exchange Format) support for both ISO14443A and ISO15693 card types.
Changes:
- Corrected byte offset parsing in
ISO15693Card.get_system_information()to properly read system information flags and fields - Added
decode_ccandget_ndefmethods to bothISO14443ACardandISO15693Cardclasses for NDEF message parsing - Updated example scripts to demonstrate NDEF reading functionality
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_iso15693.py | Comprehensive test suite for ISO15693 NDEF functionality including CC decoding and TLV parsing |
| tests/test_iso14443a_ndef.py | Comprehensive test suite for ISO14443A NDEF functionality including CC decoding and TLV parsing |
| src/pn5180_tagomatic/session.py | Removed redundant parentheses from tuple unpacking operations |
| src/pn5180_tagomatic/iso15693.py | Fixed system information parsing bugs and added NDEF support methods |
| src/pn5180_tagomatic/iso14443a.py | Added NDEF support with decode_cc and get_ndef methods |
| src/pn5180_tagomatic/cards.py | Added abstract get_ndef method to Card base class |
| examples/iso_15693-read-memory.py | Added NDEF extraction and display to memory reading example |
| examples/iso_14443-read-memory.py | Added NDEF extraction and display to memory reading example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.