Skip to content

Conversation

@InflexCZE
Copy link

When range-iterating MemoryPool, when there are exactly N x SIZE records, the iterator will fail to stop at last block and continue reading from nullptr chunk.

This typically crashes at SaveCapture -> DumpFrames -> DumpSummary when reading frames.
https://github.com/bombomby/optick/blob/master/src/optick_core.cpp#L1134

Simple reproduction

Optick::StartCapture();
for (128)
{
   RecordFrame();
}
Optick::SaveCapture();


When range-iterating MemoryPool, when there are exactly N x SIZE records, the iterator will fail to stop at last block and continue reading from nullptr chunk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant