refactor: remove duplicated types #253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was
dist/index.d.tsanddist/index.d.mtswith the same content. With this PR, onlyindex.d.mtsis kept. As"types"is using.d.mts, only TypeScript 4.7 and above will work, which I think should be ok considering that it's nearly 3 years ago and we're modernizing the package.Ideally sticking with
index.d.tsand removingindex.d.mtscould help with compatibility, but it doesn't seem configurable with unbuild.(I didn't add a changeset as this could be part of the ESM-only changeset, but let me know if needed)