Skip to content

Conversation

@bluwy
Copy link
Contributor

@bluwy bluwy commented Mar 28, 2025

There was dist/index.d.ts and dist/index.d.mts with the same content. With this PR, only index.d.mts is kept. As "types" is using .d.mts, only TypeScript 4.7 and above will work, which I think should be ok considering that it's nearly 3 years ago and we're modernizing the package.

Ideally sticking with index.d.ts and removing index.d.mts could help with compatibility, but it doesn't seem configurable with unbuild.

(I didn't add a changeset as this could be part of the ESM-only changeset, but let me know if needed)

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2025

⚠️ No Changeset found

Latest commit: e22c83a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 28, 2025

Open in Stackblitz@example/basic@example/changesets

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/core@253
npm i https://pkg.pr.new/bombshell-dev/clack/@clack/prompts@253

commit: e22c83a

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @bluwy 🫡

@dreyfus92 dreyfus92 merged commit 9cf1cc3 into bombshell-dev:main Mar 29, 2025
5 checks passed
@natemoo-re natemoo-re added the backport This PR should be cherry-picked onto v0 label Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR should be cherry-picked onto v0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants