feat: add selectableGroups option to group multi-select
#255
Conversation
Adds a `selectableGroups` boolean flag which can be used to disallow selecting groups. This basically just skips over them when using up/down, but still renders when they are "selected" (by selecting all the children individually).
🦋 Changeset detectedLatest commit: e85b846 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Open in Stackblitz • @example/basic • @example/changesets commit: |
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
Nice, thank you for the PR!
|
@AdrianGonz97 are you able to take a look at this and let me know if it matches what you have in svelte's fork? the behaviour is basically that we render everything as before, but you can't select groups if if you select all the children of a group, it will show as selected. but you can't select it yourself |
|
i see a missing part actually in the svelte fork, they also render a different prefix depending on if the groups are selectable or not. i'll take a look at that 👍 |
|
ok should be the same now this is how it looks with this is how it looks with |
dreyfus92
left a comment
dreyfus92
left a comment
There was a problem hiding this comment.
james, at first glance it looks good but, i just have a question. would it be necessary to add some tests for this?
|
Definitely We are missing quite a few tests so I might add them in a standalone PR first. I'll take a look |
Co-authored-by: Nate Moore <[email protected]>
Adds a
selectableGroupsboolean flag which can be used to disallow selecting groups.This basically just skips over them when using up/down, but still renders when they are "selected" (by selecting all the children individually).