Skip to content

fix: use placeholder as value when input is empty #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
natemoo-re merged 11 commits into from
Apr 8, 2025
Merged

fix: use placeholder as value when input is empty #263

Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e0026f6
fix: update `text` function
jsparkdev Apr 1, 2025
e1af748
update
jsparkdev Apr 2, 2025
5cd18ea
update for empty string default value
jsparkdev Apr 3, 2025
885d37e
update logic for pressing enter key without input value
jsparkdev Apr 3, 2025
651f1b1
remove changes in text prompt
jsparkdev Apr 3, 2025
fe84565
update prompt
jsparkdev Apr 3, 2025
9d4aaed
Merge branch 'main' into placeholder
jsparkdev Apr 7, 2025
8f389e9
update prompt code and test case
jsparkdev Apr 7, 2025
f256a06
code format
jsparkdev Apr 7, 2025
dafdf82
remove comment
jsparkdev Apr 7, 2025
bc1c865
Create hot-turkeys-knock.md
natemoo-re Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/core/src/prompts/prompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export interface PromptOptions<Self extends Prompt> {
render(this: Omit<Self, 'prompt'>): string | undefined;
placeholder?: string;
initialValue?: any;
defaultValue?: string;
validate?: ((value: any) => string | Error | undefined) | undefined;
input?: Readable;
output?: Writable;
Expand Down Expand Up @@ -194,10 +195,15 @@ export default class Prompt {
if (char && (char.toLowerCase() === 'y' || char.toLowerCase() === 'n')) {
this.emit('confirm', char.toLowerCase() === 'y');
}
if (char === '\t' && this.opts.placeholder) {
if ((char === '\t' || key?.name === 'return') && this.opts.placeholder) {
if (!this.value) {
this.rl?.write(this.opts.placeholder);
this.emit('value', this.opts.placeholder);
if (this.opts.defaultValue) {
this.value = this.opts.defaultValue;
this.emit('value', this.value);
} else {
this.rl?.write(this.opts.placeholder);
this.emit('value', this.opts.placeholder);
}
}
}
if (char) {
Expand Down