fix: export spinner type and add tests #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exports a `SpinnerResult` which is the API `spinner` produces. Also adds initial tests for the `prompts` package.
🦋 Changeset detectedLatest commit: c9ae56a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@example/basic • @example/changesets commit: |
dreyfus92
reviewed
Apr 3, 2025
Member
dreyfus92
left a comment
dreyfus92
left a comment
There was a problem hiding this comment.
just a nit, aside from it LGTM 😁
Co-authored-by: Paul Valladares <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exports a
SpinnerResultwhich is the APIspinnerproduces.Also adds initial tests for the
promptspackage.Notable changes:
blockconsumes aReadableandWritablenow so we can pass our own in when testing (instead ofprocess.stdoutetc)spinneraccepts anoutputoption, maybe we want to move this into a "base options" one day that all prompts acceptFixes #248