Skip to content

Conversation

@dreyfus92
Copy link
Member

@dreyfus92 dreyfus92 commented Apr 6, 2025

Closes: #130

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2025

⚠️ No Changeset found

Latest commit: 076fdb1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 6, 2025

@example/basic@example/changesets

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/core@277
npm i https://pkg.pr.new/bombshell-dev/clack/@clack/prompts@277

commit: 076fdb1

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job on this! Super thorough.

Just checking, is this adapted from anywhere? If it is, I'd love to add an acknowledgements section at the end to credit the source

@dreyfus92
Copy link
Member Author

@natemoo-re i've added the acknowledgements section, if you want to add anything else let me know! 😁

Copy link
Collaborator

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me 🥳

@dreyfus92
Copy link
Member Author

Thank you both for your reviews 🫡

@dreyfus92 dreyfus92 merged commit 0146d83 into main Apr 7, 2025
6 checks passed
@dreyfus92 dreyfus92 deleted the feat/contributing-guide branch April 7, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contribution Guide

4 participants