Skip to content

Conversation

@btea
Copy link
Contributor

@btea btea commented Jun 22, 2025

When the text method is called, and a message with spaces before and after it is entered in the terminal, a, and then the operation is canceled, you can see that the entered message is deleted, but the space after the message is also removed. The displayed message is inconsistent with the input.

before after
image image

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2025

⚠️ No Changeset found

Latest commit: 0c93488

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@43081j
Copy link
Collaborator

43081j commented Jun 22, 2025

you've actually uncovered a bit of a pandora's box here

i think we should be turning off trimming unconditionally, and should fix up our prompts to no longer have trailing space

i have a WIP branch where i've started to do this. so, assuming i get it working, i can merge into main before this and you can update your change here to just set trim: false.

remember to also set it inside the restoreCursor method though, too

@43081j
Copy link
Collaborator

43081j commented Jun 22, 2025

#351

@btea
Copy link
Contributor Author

btea commented Jun 23, 2025

Thanks for your review and work. Ok, let's close this PR.

@btea btea closed this Jun 23, 2025
@43081j
Copy link
Collaborator

43081j commented Jun 23, 2025

i actually meant we should still use this PR once i merge the other one

but no worries, i can make the change in my PR too 👍

@btea
Copy link
Contributor Author

btea commented Jun 24, 2025

It seems I misunderstood what you meant, but you can put this modification together with your PR. 👍

@btea btea deleted the fix/correct-show-cancel-message branch June 24, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants