-
Notifications
You must be signed in to change notification settings - Fork 161
feat: box prompt #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: box prompt #363
Conversation
🦋 Changeset detectedLatest commit: f2936c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@example/basic • @example/changesets commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is so cool, but wouldn't it be cooler if you could add a color prop to modify the color border of the box? or even the title?
thank you for adding tests btw, LGTM 🤘🏻
|
i think you're right but i want to avoid some kind of maybe we should do what basically so you bring your own formatting, like |
|
i've added a box('some message', 'some title', {
formatBorder: styleText.bind(null, 'red'), // or picocolors.red
}); |
dreyfus92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's ship it 🤘🏻
Adds a new
boxprompt which works like so:For reviewers
Feedback i'd like on this:
includePrefixmake sense? Basically its to tell the box to output the usual|bar before it, so if it is part of a group of prompts it will fit in. If you set it tofalse(the default), it won't output thisnoteprompt. It may be argued that we should just add the functionality to that instead of having a separate prompt