Skip to content

Conversation

@chouchouji
Copy link
Contributor

@chouchouji chouchouji commented Aug 10, 2025

@43081j , It is an amazing library and helps me a lot. Thanks for all your work in this repo.

I see we have precise type in this link.

image

So should we use more accurate type to replace any in another file? This will make our code clearer. If you have some suggestions for this pr. Please tell me directly. Thanks again.

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2025

🦋 Changeset detected

Latest commit: c500960

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clack/prompts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 👍

thanks for the contribution

@chouchouji
Copy link
Contributor Author

makes sense 👍

thanks for the contribution

Thanks. I don't know why the ci job failed. What's the best way to fix this?

@43081j
Copy link
Collaborator

43081j commented Aug 10, 2025

@dreyfus92 is going to look into it, its happening on all PRs 👍

once we figure that out, we can merge this

@chouchouji
Copy link
Contributor Author

@dreyfus92 is going to look into it, its happening on all PRs 👍

once we figure that out, we can merge this

OK, I get it. Thanks for all your efforts!

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 10, 2025

@example/basic@example/changesets

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/core@369
npm i https://pkg.pr.new/bombshell-dev/clack/@clack/prompts@369

commit: c500960

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i fixed the pipeline, awesome work @chouchouji and btw, would you mind adding a changeset about this patch?

@chouchouji
Copy link
Contributor Author

chouchouji commented Aug 11, 2025

i think i fixed the pipeline, awesome work @chouchouji and btw, would you mind adding a changeset about this patch?

Thanks! I will add a changeset today.

@chouchouji chouchouji force-pushed the group-multi-select-types branch from a6905b2 to a139ef5 Compare August 11, 2025 05:23
@chouchouji
Copy link
Contributor Author

i think i fixed the pipeline, awesome work @chouchouji and btw, would you mind adding a changeset about this patch?

I have added a patch. Please check it.

@43081j 43081j merged commit 4c89dd7 into bombshell-dev:main Aug 11, 2025
7 checks passed
@chouchouji chouchouji deleted the group-multi-select-types branch August 11, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants