Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/short-squids-battle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@clack/prompts": patch
---

Handle `stop` calls on spinners which have not yet been started.
1 change: 1 addition & 0 deletions packages/prompts/src/spinner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ export const spinner = ({
};

const stop = (msg = '', code = 0): void => {
if (!isSpinnerActive) return;
isSpinnerActive = false;
clearInterval(loop);
clearPrevMessage();
Expand Down
6 changes: 6 additions & 0 deletions packages/prompts/test/spinner.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,12 @@ describe.each(['true', 'false'])('spinner (isCI = %s)', (isCI) => {

expect(output.buffer).toMatchSnapshot();
});

test('does not throw if called before start', () => {
const result = prompts.spinner({ output });

expect(() => result.stop()).not.toThrow();
});
});

describe('message', () => {
Expand Down
Loading