Conversation
commit: |
commit: |
|
43081j
reviewed
Mar 9, 2025
43081j
reviewed
Mar 9, 2025
Member
Author
|
@43081j, i think i've sorted out my mess 😭 |
43081j
reviewed
Apr 3, 2025
- Add missing serve command to demo.cac.ts to correct CLI test snapshots - Implement suggestion to use toMatchSnapshot() for fish shell tests - Update snapshots to include proper completions
Collaborator
|
any updates on this? |
Member
Author
|
@Aslemammad i finished fixing, i've been waiting for someone to take a look and review 🫣 |
AmirSa12
pushed a commit
that referenced
this pull request
Apr 28, 2025
* feat: add fish.ts & bash.ts * fix: format * cleanup: remove unused type definition * apply suggestions from @43081j review * fix: format * moar cleanup * fix: add missing serve command to demo.cac.ts to correct CLI test snapshots * fix: add serve command and use snapshot testing for shells - Add missing serve command to demo.cac.ts to correct CLI test snapshots - Implement suggestion to use toMatchSnapshot() for fish shell tests - Update snapshots to include proper completions
AmirSa12
pushed a commit
that referenced
this pull request
Apr 29, 2025
* feat: add fish.ts & bash.ts * fix: format * cleanup: remove unused type definition * apply suggestions from @43081j review * fix: format * moar cleanup * fix: add missing serve command to demo.cac.ts to correct CLI test snapshots * fix: add serve command and use snapshot testing for shells - Add missing serve command to demo.cac.ts to correct CLI test snapshots - Implement suggestion to use toMatchSnapshot() for fish shell tests - Update snapshots to include proper completions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examplesdirectory.