Skip to content

feat: autocomplete clis executing through a package manager#26

Merged
AmirSa12 merged 11 commits intofeat/pnpm-scriptfrom
feat/pnpm-main
Jul 26, 2025
Merged

feat: autocomplete clis executing through a package manager#26
AmirSa12 merged 11 commits intofeat/pnpm-scriptfrom
feat/pnpm-main

Conversation

@AmirSa12
Copy link
Member

@AmirSa12 AmirSa12 commented May 2, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: 750d2dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AmirSa12 AmirSa12 marked this pull request as draft May 2, 2025 14:43
@pkg-pr-new
Copy link

pkg-pr-new bot commented May 2, 2025

Open in StackBlitz

npm i https://pkg.pr.new/bombshell-dev/tab/@bombsh/tab@26

commit: 750d2dd

@AmirSa12 AmirSa12 changed the base branch from main to feat/pnpm-script May 2, 2025 14:44
Copy link
Collaborator

@Aslemammad Aslemammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing stuff, you're moving in the right direction.

@Aslemammad
Copy link
Collaborator

as a goal for this PR, the pkg.pr.new output of this PR should achieve the goal of npx https://pkg.pr.new/bombshell-dev/tab/@bombsh/tab@26 pnpm zsh and other possible values. So things should be testable that way.

@AmirSa12
Copy link
Member Author

AmirSa12 commented May 4, 2025

added onBeforeParse hook in the completion class, it provides a way to extend the completions without modifying the core behavior and also, it allows us to intercept completion requests before the standard parsing logic runs.
this also gives us the opportunity to detect and handle cli tool that are not a part of standard pnpm ( in this case ) commands.

@AmirSa12 AmirSa12 requested review from 43081j and dreyfus92 May 4, 2025 13:53
@bombshell-dev bombshell-dev deleted a comment from Aslemammad Jul 7, 2025
@AmirSa12 AmirSa12 marked this pull request as ready for review July 26, 2025 19:54
@AmirSa12
Copy link
Member Author

Continuing this here #23

@AmirSa12 AmirSa12 merged commit e9352b4 into feat/pnpm-script Jul 26, 2025
5 checks passed
@AmirSa12 AmirSa12 deleted the feat/pnpm-main branch July 26, 2025 19:56
AmirSa12 added a commit that referenced this pull request Aug 4, 2025
* init

* update

* new implementation

* prettier

* feat: autocomplete clis executing through a package manager (#26)

* init

* prettier

* update

* cli completions

* pnpm install

* fix: handle complete command manually

* fix: completion-handler __complete => complete

* fix: remove examples form package.json

* fix: generateCompletionScript function

* move the package manager completion logic directly into the parse method

* prettier

* tab -> t wip

* before some ai changes

* huge wip

* grammar issues

* prettier

---------

Co-authored-by: Mohammad Bagher Abiyat <37929992+Aslemammad@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants