fix: separate pkg manager completion handling from the core API #31
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| import { execSync } from 'child_process'; | ||
| import { RootCommand } from '../src/t.js'; | ||
|
|
||
| function debugLog(...args: any[]) { | ||
| if (process.env.DEBUG) { | ||
| console.error('[DEBUG]', ...args); | ||
| } | ||
| } | ||
|
|
||
| async function checkCliHasCompletions( | ||
| cliName: string, | ||
| packageManager: string | ||
| ): Promise<boolean> { | ||
| try { | ||
| debugLog(`Checking if ${cliName} has completions via ${packageManager}`); | ||
| const command = `${packageManager} ${cliName} complete --`; | ||
| const result = execSync(command, { | ||
| encoding: 'utf8', | ||
| stdio: ['pipe', 'pipe', 'ignore'], | ||
| timeout: 1000, | ||
| }); | ||
| const hasCompletions = !!result.trim(); | ||
| debugLog(`${cliName} supports completions: ${hasCompletions}`); | ||
| return hasCompletions; | ||
| } catch (error) { | ||
| debugLog(`Error checking completions for ${cliName}:`, error); | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| async function getCliCompletions( | ||
|
Collaborator
There was a problem hiding this comment. this function and checkCliHasCompletions has so much redundancy and i feel they're heavily similar. |
||
| cliName: string, | ||
| packageManager: string, | ||
| args: string[] | ||
| ): Promise<string[]> { | ||
| try { | ||
| const completeArgs = args.map((arg) => | ||
| arg.includes(' ') ? `"${arg}"` : arg | ||
| ); | ||
| const completeCommand = `${packageManager} ${cliName} complete -- ${completeArgs.join(' ')}`; | ||
| debugLog(`Getting completions with command: ${completeCommand}`); | ||
|
|
||
| const result = execSync(completeCommand, { | ||
| encoding: 'utf8', | ||
| stdio: ['pipe', 'pipe', 'ignore'], | ||
| timeout: 1000, | ||
| }); | ||
|
|
||
| const completions = result.trim().split('\n').filter(Boolean); | ||
| debugLog(`Got ${completions.length} completions from ${cliName}`); | ||
| return completions; | ||
| } catch (error) { | ||
| debugLog(`Error getting completions from ${cliName}:`, error); | ||
| return []; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Package Manager Completion Wrapper | ||
| * | ||
| * This extends RootCommand and adds package manager-specific logic. | ||
| * It acts as a layer on top of the core tab library. | ||
| */ | ||
| export class PackageManagerCompletion extends RootCommand { | ||
|
Collaborator
There was a problem hiding this comment. i do not think we need this class, it can be done through some imperative functions and calls.
Collaborator
There was a problem hiding this comment. let's remove it and revisit the implementation. it's a bit hard to understand this implementation for me.
Collaborator
There was a problem hiding this comment. and we need tests for the package manager completions. |
||
| private packageManager: string; | ||
|
|
||
| constructor(packageManager: string) { | ||
| super(); | ||
| this.packageManager = packageManager; | ||
| } | ||
|
|
||
| // Enhanced parse method with package manager logic | ||
| async parse(args: string[]) { | ||
| // Handle package manager completions first | ||
| if (args.length >= 1 && args[0].trim() !== '') { | ||
| const potentialCliName = args[0]; | ||
| const knownCommands = [...this.commands.keys()]; | ||
|
|
||
| if (!knownCommands.includes(potentialCliName)) { | ||
| const hasCompletions = await checkCliHasCompletions( | ||
| potentialCliName, | ||
| this.packageManager | ||
| ); | ||
|
|
||
| if (hasCompletions) { | ||
| const cliArgs = args.slice(1); | ||
| const suggestions = await getCliCompletions( | ||
| potentialCliName, | ||
| this.packageManager, | ||
| cliArgs | ||
| ); | ||
|
|
||
| if (suggestions.length > 0) { | ||
| // Print completions directly in the same format as the core library | ||
| for (const suggestion of suggestions) { | ||
| if (suggestion.startsWith(':')) continue; | ||
|
|
||
| if (suggestion.includes('\t')) { | ||
| const [value, description] = suggestion.split('\t'); | ||
| console.log(`${value}\t${description}`); | ||
| } else { | ||
| console.log(suggestion); | ||
| } | ||
| } | ||
| console.log(':4'); // Shell completion directive (NoFileComp) | ||
| return; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Fall back to regular completion logic (shows basic package manager commands) | ||
| return super.parse(args); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i do not see any completion for all of these commands, we should provide for all of them before release. that's what we agreed on as far as i remember.