Skip to content

Allow adding integers to enum value #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −7
Open

Allow adding integers to enum value #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fef27a
Regression test for adding enum value and integer
glopesdev Nov 29, 2025
97341f0
Update System.Linq.Dynamic.Core version
glopesdev Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Bonsai.Scripting.Expressions.Tests/Bonsai.Scripting.Expressions.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
<PackageReference Include="MSTest.TestAdapter" Version="3.8.3" />
<PackageReference Include="MSTest.TestFramework" Version="3.8.3" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
<PackageReference Include="MSTest.TestAdapter" Version="4.0.2" />
<PackageReference Include="MSTest.TestFramework" Version="4.0.2" />
</ItemGroup>

<ItemGroup>
Expand Down
7 changes: 4 additions & 3 deletions src/Bonsai.Scripting.Expressions.Tests/ExpressionScriptingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ async Task AssertExpressionTransform<TSource, TResult>(string expression, TSourc
Assert.AreEqual(expected, result);
}

[DataTestMethod]
[TestMethod]
[DataRow("it", 42, 42)]
[DataRow("it * 2", 21, 42)]
[DataRow("Single(it)", 42, 42f)]
Expand All @@ -38,6 +38,7 @@ async Task AssertExpressionTransform<TSource, TResult>(string expression, TSourc
[DataRow("new[] { it }", 42, new[] { 42 })]
[DataRow("new[] { it }.Select(x => x * 2).ToArray()", 21, new[] { 42 })]
[DataRow("np(string(null).Length) ?? it", 42, 42)]
[DataRow("DayOfWeek(it + 1)", DayOfWeek.Monday, DayOfWeek.Tuesday)]
public Task TestExpressionTransform<TSource, TResult>(string expression, TSource value, TResult expected)
{
return AssertExpressionTransform(expression, value, expected);
Expand All @@ -52,7 +53,7 @@ public Task TestExpressionTransform<TSource, TResult>(string expression, TSource
[TestMethod]
public Task TestObjectExpression() => AssertExpressionTransform("object(it)", 42, (object)42);

[DataTestMethod]
[TestMethod]
[DataRow("single(it)", 42, 42f)]
[DataRow("int64?(it).hasvalue", 42, true)]
[DataRow("math.pi", 42, Math.PI)]
Expand All @@ -69,7 +70,7 @@ public Task TestCasingCompatibility<TSource, TResult>(string expression, TSource
return AssertExpressionTransform(expression, value, expected);
}

[DataTestMethod]
[TestMethod]
[DataRow("")]
[DataRow("string(it)")]
public Task TestInvalidExpression(string expression)
Expand Down
2 changes: 1 addition & 1 deletion src/Bonsai.Scripting.Expressions/Bonsai.Scripting.Expressions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Bonsai.Core" Version="2.9.0" />
<PackageReference Include="System.Linq.Dynamic.Core" Version="1.6.7" />
<PackageReference Include="System.Linq.Dynamic.Core" Version="1.7.1" />
</ItemGroup>
</Project>