Replace int Streamtype property with enum#13
Merged
glopesdev merged 2 commits intobonsai-rx:mainfrom Nov 23, 2025
Merged
Conversation
Make StreamType enum in Fetch.cs and update stream type property to use it. Update Fetch examples accordingly.
glopesdev
reviewed
Nov 21, 2025
glopesdev
approved these changes
Nov 23, 2025
J-M-White
deleted the
11-consider-replacing-integer-settings-with-enum-properties
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #11, it would be nice to use an enum instead of ints for the
StreamTypeproperty ofFetch.Here, we make the
StreamTypefor this. We also update theFetchexample workflows accordingly.Closes #11