Skip to content

feat: add fix suggestions for dark mode theme issues#167

Merged
himerus merged 2 commits intodevfrom
feature/suggest-fix-dark-mode-issues
Mar 21, 2026
Merged

feat: add fix suggestions for dark mode theme issues#167
himerus merged 2 commits intodevfrom
feature/suggest-fix-dark-mode-issues

Conversation

@himerus
Copy link
Contributor

@himerus himerus commented Mar 21, 2026

Summary

  • Extends suggest_fix to handle mixed-token-hardcoded issues (wraps hardcoded value in var())
  • Extends suggest_fix to handle dark-mode-shadow-invisible issues (suggests shadow token)
  • Both respect tokenPrefix for library-agnostic suggestions

Test plan

  • 3 new tests: mixed-token-hardcoded fix, shadow-invisible fix, tokenPrefix on shadow fix
  • All 35 suggest-fix tests pass
  • Type checks clean

🤖 Generated with Claude Code

Extends suggest_fix to handle mixed-token-hardcoded and
dark-mode-shadow-invisible issues from the enhanced
theme checker. Both generate var()-based suggestions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 21, 2026

Warning

Rate limit exceeded

@himerus has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 47 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c6a9ad16-814f-443b-ba2f-555401f00b0e

📥 Commits

Reviewing files that changed from the base of the PR and between c1e5f29 and fc95c1c.

📒 Files selected for processing (4)
  • .changeset/suggest-fix-dark-mode.md
  • packages/core/src/handlers/suggest-fix.ts
  • packages/core/src/handlers/validation-summary.ts
  • tests/handlers/suggest-fix.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/suggest-fix-dark-mode-issues

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Theme compatibility issues in validate_component_code
now include fix suggestions via tryAutoFix, matching
how shadow-dom and token-fallback issues work.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@himerus himerus merged commit b4d8aee into dev Mar 21, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant