Skip to content

feat: add common mistakes section to component narrative#168

Merged
himerus merged 1 commit intodevfrom
feature/narrative-common-mistakes
Mar 21, 2026
Merged

feat: add common mistakes section to component narrative#168
himerus merged 1 commit intodevfrom
feature/narrative-common-mistakes

Conversation

@himerus
Copy link
Contributor

@himerus himerus commented Mar 21, 2026

Summary

  • Adds a component-specific "Common mistakes" section to get_component_narrative output
  • Lists valid CSS part names with warning that others silently fail
  • Warns when component has no CSS parts (use properties only) or no CSS API at all
  • Flags custom events (with hyphens) that won't work with React onXxx props
  • Reminds agents to validate CSS with styling_preflight

Test plan

  • 5 new tests: valid parts listed, no-parts warning, no-CSS-API warning, React event warning, preflight reminder
  • All 20 narrative tests pass
  • Build, type-check, lint all clean

🤖 Generated with Claude Code

Generates component-specific warnings based on API:
- Lists valid part names (any other will silently fail)
- Warns when component has no CSS parts or no CSS API
- Flags custom events that break React onXxx props
- Reminds to validate with styling_preflight

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 21, 2026

Warning

Rate limit exceeded

@himerus has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 9 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: f5938b36-1f73-4f1d-bd67-5a13fcd44f3c

📥 Commits

Reviewing files that changed from the base of the PR and between b4d8aee and ce9ed84.

📒 Files selected for processing (3)
  • .changeset/narrative-common-mistakes.md
  • packages/core/src/handlers/narrative.ts
  • tests/handlers/narrative.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/narrative-common-mistakes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@himerus himerus merged commit 73f9cac into dev Mar 21, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant