chore: regenerate custom-elements.json from source#169
Conversation
CEM was stale — regenerate to fix cem-validate CI check. This updates the manifest to reflect all recent handler and tool additions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR adds a substantial number of new handler modules to the core package for validation and diagnostics, including checkers for accessibility, attributes, CSS properties, composition, events, methods, shadow DOM, slots, and theming. It also introduces a new styling tools module with dispatcher utilities and expands public API exports via updated manifest mappings. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@custom-elements.json`:
- Around line 2791-2795: The parameter includeTransitive in the function located
in packages/core/src/handlers/dependencies.ts is declared without an explicit
type (currently "includeTransitive = true"); add an explicit boolean annotation
(change to includeTransitive: boolean = true) so the generated manifest includes
the type field, then regenerate the custom-elements.json manifest; reference the
includeTransitive parameter in that handler to locate the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 1d2c2f72-0219-42a6-914e-4fff9654d06b
📒 Files selected for processing (1)
custom-elements.json
| { | ||
| "name": "includeTransitive", | ||
| "default": "true", | ||
| "description": "When true (default), resolves the full dep tree" | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo '== source signature =='
rg -n -C2 --type ts 'getComponentDependencies\s*\(' packages/core/src/handlers/dependencies.ts
echo
echo '== generated manifest entry =='
rg -n -C2 '"includeTransitive"' custom-elements.jsonRepository: bookedsolidtech/helixir
Length of output: 479
🏁 Script executed:
sed -n '90,110p' packages/core/src/handlers/dependencies.tsRepository: bookedsolidtech/helixir
Length of output: 538
Type includeTransitive explicitly in source.
The includeTransitive parameter in packages/core/src/handlers/dependencies.ts (line 91) is declared as includeTransitive = true without an explicit type annotation. This causes the generated manifest to omit the type field, losing the boolean signature for downstream CEM consumers. Add an explicit : boolean annotation and regenerate the manifest.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@custom-elements.json` around lines 2791 - 2795, The parameter
includeTransitive in the function located in
packages/core/src/handlers/dependencies.ts is declared without an explicit type
(currently "includeTransitive = true"); add an explicit boolean annotation
(change to includeTransitive: boolean = true) so the generated manifest includes
the type field, then regenerate the custom-elements.json manifest; reference the
includeTransitive parameter in that handler to locate the change.
chore: promote dev → main (sprint PRs #169-171)
Summary
cem-validateCI check that's been failing on every PRTest plan
pnpm run cem:generatesucceeds🤖 Generated with Claude Code
Summary by CodeRabbit