Skip to content

feat: add dark-mode fix category to suggest_fix#183

Merged
himerus merged 4 commits intodevfrom
feat/suggest-fix-dark-mode
Mar 21, 2026
Merged

feat: add dark-mode fix category to suggest_fix#183
himerus merged 4 commits intodevfrom
feat/suggest-fix-dark-mode

Conversation

@himerus
Copy link
Contributor

@himerus himerus commented Mar 21, 2026

Summary\n\n- Adds dark-mode fix type to suggest_fix covering both issue rules from check_dark_mode_patterns\n- theme-scope-standard-property: generates CSS custom property replacement with tokenPrefix support\n- theme-scope-shadow-piercing: suggests ::part() or custom properties with host-only selector\n- 4 new tests covering all dark mode fix paths\n\n## Test plan\n- [x] All 39 suggest-fix tests pass\n- [x] Standard property fix uses component tag name for token naming\n- [x] tokenPrefix override works correctly\n- [x] Shadow piercing fix shows both ::part() and custom property options\n\n🤖 Generated with Claude Code

himerus and others added 2 commits March 21, 2026 04:54
Adds fixDarkMode handler covering theme-scope-standard-property and
theme-scope-shadow-piercing issues. Generates concrete CSS custom
property replacements with tokenPrefix support.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 21, 2026

Warning

Rate limit exceeded

@himerus has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: de9c05ab-1e4c-4df4-ac79-0a9e2d090c82

📥 Commits

Reviewing files that changed from the base of the PR and between f66f36d and 77c4b1d.

📒 Files selected for processing (6)
  • .changeset/suggest-fix-dark-mode.md
  • packages/core/src/handlers/css-file-validator.ts
  • packages/core/src/handlers/quick-ref.ts
  • packages/core/src/handlers/styling-preflight.ts
  • packages/core/src/handlers/suggest-fix.ts
  • tests/handlers/suggest-fix.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/suggest-fix-dark-mode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

himerus and others added 2 commits March 21, 2026 04:56
Maps darkMode category to suggest_fix dark-mode type in both
styling_preflight and css-file-validator. Dark mode issues now get
concrete fix suggestions with CSS custom property replacements.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds component-specific dark mode warning for components with CSS
custom properties — warns against using standard properties on the host
in theme scopes and shows the correct custom property approach.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@himerus himerus merged commit d8e1412 into dev Mar 21, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant