Skip to content

Specify metadata about an author's relationship to a book#2212

Draft
mouse-reeve wants to merge 12 commits intomainfrom
author-table
Draft

Specify metadata about an author's relationship to a book#2212
mouse-reeve wants to merge 12 commits intomainfrom
author-table

Conversation

@mouse-reeve
Copy link
Copy Markdown
Member

@mouse-reeve mouse-reeve commented Jul 9, 2022 •
edited
Loading

This PR creates an explicit join table for the many-to-many relationship between Book and Author, which contains a field for the type of author (ie, author, illustrator, translator, etc).

The current list of author types is:

    ("author", _("Author")),
    ("editor", _("Editor")),
    ("translator", _("Translator")),
    ("contributor", _("Contributor")),
    ("preface", _("Author of Preface")),
    ("illustrator", _("Illustrator")),
    ("letterer", _("Letterer")),
    ("narrator", _("Narrator")),
    ("other", _("Other")),

Work:

  • Create new join table
  • Write migration
  • Update search vector triggers
  • Display author type in the UI
  • Make author type editable
  • Specify author type in ActivityPub

Fixes #1120
Fixes #1944

@mouse-reeve
Prepares a join table between Book and Author
4a980cd 
This will allow any number of good things, like specifying types of
authors. Notice that this join table isn't joined right now -- Django
can't handle that complex a migration.
@mouse-reeve
Adds SQL steps to move author data to the new table
ef833f0
@mouse-reeve
Preserve PSQL table name for author join table
9f69477
jaschaurbach
jaschaurbach reviewed Dec 19, 2022
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaschaurbach jaschaurbach jaschaurbach left review comments

+1 more reviewer

@Blechpirat Blechpirat Blechpirat left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple Types of Authors Add illustrator field for books

3 participants

@mouse-reeve @jaschaurbach @Blechpirat