Make series a separate model

[hughrun]

Description

This PR moves book series to a pair of new models: Series and SeriesBook. This will allow more consistency around series, and for books to be matched to series regardless of whether they share an author. Basically it makes series "things, not strings".

A Series has basic BookData to better enable us to de-duplicate them, although only series imported from Inventaire are likely to have anything beyond a name. A SeriesBook connects a Series to a Book, including a series_number: it's the instantiation of a Book being part of a series.

When saving a book, users will be prompted to confirm whether it is part of an existing series, in the same way we check for existing authors.

All importers will now convert series information to a SeriesBook and Series where possible. If there is a matching series but no other book in the series with a matching author, the series information is left on the incoming book and users will be prompted to confirm the series information manually on the book view page.

Series can be edited, including updating the seriesnumber on one or more seriesbooks - users need to have permission to edit books to do this.

Creating a data migration proved to be challenging, so I have instead created an admin command to convert "legacy" series to Series and SeriesBooks where possible. This will need to be run by admins manually.

I have tried to make this backwards-compatible but it's entirely possibly that I've missed something.

I also added an atomic block to the user export model which is entirely unrelated except that I made a mistake when I was testing, and without this block I got a bunch of obscure errors.

This was a bit of a beast to put together so there may well be parts that could be more efficient or that I've missed - happy for any feedback!

• Related Issue Proposal: Authority control and better modelling for contributors and series #3681 [Feature Request] automatic Book-series-list to keep track of your book series #2959
• Closes Multiple series to a single book #3579
• Closes Move series membership from Edition to Work #3306
• Closes Series are tied to the first-named author in each edition #2991

What type of Pull Request is this?

• Bug Fix
• Enhancement
• Plumbing / Internals / Dependencies
• Refactor

Does this PR change settings or dependencies, or break something?

• This PR changes or adds default settings, configuration, or .env values
• This PR changes or adds dependencies
• This PR introduces other breaking changes

Details of breaking or configuration changes (if any of above checked)

Documentation

• New or amended documentation will be required if this PR is merged
• I have created a matching pull request in the Documentation repository
• I intend to create a matching pull request in the Documentation repository after this PR is merged

Tests

• My changes do not need new tests
• All tests I have added are passing
• I have written tests but need help to make them pass
• I have not written tests and need help to write them

[hughrun]

hmm. Not sure why this NotifyInviteRequest test is failing, I didn't do anything to notifications. I suspect something about ordering/concurrency in the test suite?

[ilkka-ollakka]

hmm. Not sure why this NotifyInviteRequest test is failing, I didn't do anything to notifications. I suspect something about ordering/concurrency in the test suite?

I didn't manage to reproduce the failure locally either.

[ilkka-ollakka]

I think this looks good. The failing test is something that could be tried to reproduce but shouldn't block merging in my opinion.

[hughrun]

I can replicate this test failure locally if I run pytest with -n 3 (as per the GitHub action) but not without concurrent tests. I'm guessing there's an underlying problem and this just happens to have surfaced it.

[mouse-reeve]

I have some small tweaks, but I ran into two bugs that weren't obvious to me:

No. 1: If I add a new series with the same name as an existing series, I get this error:

FieldError at /book/18664/confirm

Cannot resolve keyword 'title' into field. Choices are: aasin, absorbed, alternative_names, asin, bnf_id, created_date, finna_key, goodreads_key, id, inventaire_id, isfdb, last_edited_by, last_edited_by_id, librarything_key, libris_key, name, openlibrary_key, origin_id, remote_id, search_vector, seriesbooks, updated_date, user, user_id, viaf, wikidata

Which traces to:
/app/bookwyrm/views/books/edit_book.py, line 378

No. 2: If I try to delete a series using the checkbox on the edit book page, I get this error:

DoesNotExist at /book/18664/edit

SeriesBook matching query does not exist.

Which traces to:
/app/bookwyrm/views/books/edit_book.py, line 74

[mouse-reeve]

I submitted fixes for all these comments on your repo, hopefully that helps??? But the two errors I found unfortunately remain

[dato]

I took a look at this PR, I have some minor comments and questions (all suggestions are optional).

Thanks!!

[mouse-reeve]

I'm sorry to be the bearer of this news, but now when I import a book without a series from Inventaire, it creates a blank string series that has a url linked from the book page, but the link leads to a 404

[hughrun]

hmm, that seems suboptimal! I must have broken the logic somewhere.