๐ fix: OAuth ์๋ฒ ๋ก๊ทธ์ธ ์ค ์คํจ์ ๋ํ ๋ฆฌ๋๋ ์ ์ถ๊ฐ#578
Open
CodeVac513 wants to merge 5 commits intomainfrom
Open
๐ fix: OAuth ์๋ฒ ๋ก๊ทธ์ธ ์ค ์คํจ์ ๋ํ ๋ฆฌ๋๋ ์
์ถ๊ฐ#578CodeVac513 wants to merge 5 commits intomainfrom
CodeVac513 wants to merge 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
๐จ ํ ์คํฌ
Issue
๐ ์์ ๋ด์ฉ
OAuth ๋ก๊ทธ์ธ ์ค ์คํจ ์ error์ ํจ๊ป JSON์ด ๋ฐํ๋๋ ๋ฌธ์ ๊ฐ ์์์ต๋๋ค.
OAuthCallbackRequestDto์ code๊ฐ not null์ด์ง๋ง, OAuth Provider ๋ก๊ทธ์ธ ์คํจ ์ error ์ฝ๋๊ฐ ์ถ๊ฐ๋๊ณ code๋ ๋ฐํ๋์ง ์๋ ๊ฒ์ ํ์ธํ์ต๋๋ค.์ฌ๊ธฐ์ code์ error๋ฅผ ๋ชจ๋ optional๋ก ์์ ํ๊ณ ,
code๊ฐ ์๊ณ error๊ฐ ์์ ๋๋ง ๋ก๊ทธ์ธ ๋ก์ง์ ์ํํ๋๋ก ์ฝ๋๋ฅผ ์์ ํ์ต๋๋ค.์ด์ error๊ฐ ๋ฐ์ํ๋ฉด signin ํ์ด์ง๋ก ๋ฆฌ๋๋ ์ ๋ฉ๋๋ค.