Conversation
| #include <boost/core/lightweight_test.hpp> | ||
| #include <iostream> | ||
|
|
||
| void fasting() |
There was a problem hiding this comment.
Not sure adding this as test is useful.
Result was always correct afaik.
This is hard to test but if you want one way to test this is to introduce detail:: helper that checks if 2 numbers can be multiplied within range of u128, and then test that helper.
Might be an overkill, but it is basically just extracting
const auto lhs_dig {detail::num_digits(lhs_sig)};
const auto rhs_dig {detail::num_digits(rhs_sig)};
return lhs_dig + rhs_dig <= std::numeric_limits<uint128>::digits10;
into bool returning helper function.
There was a problem hiding this comment.
It's a good reproducer for using the debugger. I'm not super worried about the test in this case since the special functions test suites will for sure hit both paths.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #812 +/- ##
=========================================
+ Coverage 98.9% 98.9% +0.1%
=========================================
Files 228 229 +1
Lines 16978 16987 +9
Branches 1810 1809 -1
=========================================
+ Hits 16787 16796 +9
Misses 191 191
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Closes: #802