Feature: Add find_last_one() and find_previous_one()#103
Open
gennaroprota wants to merge 2 commits intodevelopfrom
Open
Feature: Add find_last_one() and find_previous_one()#103gennaroprota wants to merge 2 commits intodevelopfrom
find_last_one() and find_previous_one()#103gennaroprota wants to merge 2 commits intodevelopfrom
Conversation
gennaroprota
force-pushed
the
feature/add_find_last_one_and_find_previous_one
branch
from
de1b9b9 to
136979e
Compare
…d_next_off"
Reason: Some people expressed a dislike for the name "find_first_off",
saying it causes confusion with "find_first_of" (although a
find_first_of() wouldn't make much sense for a bitset), so we choose a
new set of consistent names:
find_first() → find_first_one()
find_first_off() → find_first_zero()
find_next() → find_next_one()
find_next_off() → find_next_zero()
.
gennaroprota
force-pushed
the
feature/add_find_last_one_and_find_previous_one
branch
from
136979e to
fb5d038
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #103 +/- ##
===========================================
+ Coverage 96.57% 96.70% +0.13%
===========================================
Files 5 5
Lines 788 820 +32
Branches 233 242 +9
===========================================
+ Hits 761 793 +32
Misses 27 27
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
gennaroprota
force-pushed
the
feature/add_find_last_one_and_find_previous_one
branch
from
fb5d038 to
b253bd7
Compare
gennaroprota
force-pushed
the
feature/add_find_last_one_and_find_previous_one
branch
from
b253bd7 to
423f5ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.