Replace Boost::foreach dependency with range-based for#409
Replace Boost::foreach dependency with range-based for#409georgthegreat wants to merge 3 commits intoboostorg:developfrom
Conversation
|
Thanks! |
|
If there are any build failures, please investigate. |
|
@jeremy-murphy, I had to reduce the amount of changes as it turns out that range-based-for is incompatible with vertices() method (it returns std::pair which is not a range in c++ terms, yet is accepted by BOOST_FOREACH). So, publicpart is rewritten and boost/foreach is no longer included from neither Can we merge such (partial) improvement? |
|
Whilst I think it's good to get rid of macros like |
|
range-based for is much clearer to me compared to huge functional-style algorithms. As I have failed to remove this dependency, I am closing this PR. |
The library is marked as C++14, hence it should be safe to replace the dependency with native syntax.
boost::graph::verticesreturnsstd::pairwhich is not compatible with range-based for.As changing this behavior would result in API break, only public part was changed and the dependency still remains.