Use BOOST_OVERRIDE on functions that override #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with clang 19.1.7 on Alma with -Werror and a number of other flags (we run with most warnings enabled), a number of functions are flagged as overriding a function but not marked with override eg
error: 'parse' overrides a member function but is not marked 'override' [-Werror,-Wsuggest-override]. Based on older tickets, theBOOST_OVERRIDEmacro was used to address this.Env:
Alma 9.6
Boost 1.88.0 via cmake
clang 19.1.7
Replaces: #97
While ^^ addressed other issues, to keep scope and review simple, the other issues are not addressed in here.
Resolves: #93