Skip to content

install: Do a dynamic mount for /var/tmp #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cgwalters merged 1 commit into from
May 2, 2025
Merged

install: Do a dynamic mount for /var/tmp #1294

cgwalters merged 1 commit into from
May 2, 2025

Conversation

@cgwalters
Copy link
Collaborator

@cgwalters cgwalters commented May 2, 2025

Closes: #1292

Basically we were doing the /proc/1/root/var/tmp trick for /var/tmp because we didn't have the dynamic bind mount infrastructure before. Now we do, so use it instead.

The specific motivation is that Go in some cases uses EvalSymlinks which gets confused by the /proc/<pid>/root magic links.

Also, this deletes a lot of code.

@cgwalters
install: Do a dynamic mount for /var/tmp
1c30403 
Closes: bootc-dev#1292

Basically we were doing the `/proc/1/root/var/tmp` trick for
`/var/tmp` because we didn't have the dynamic bind mount infrastructure
before. Now we do, so use it instead.

The specific motivation is that Go in some cases uses `EvalSymlinks`
which gets confused by the `/proc/<pid>/root` magic links.

Also, this deletes a lot of code.

Signed-off-by: Colin Walters <[email protected]>
@github-actions github-actions bot added the area/install Issues related to `bootc install` label May 2, 2025
@cgwalters cgwalters mentioned this pull request May 2, 2025
Closed
jmarrero
jmarrero approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgwalters
Copy link
Collaborator Author

cgwalters commented May 2, 2025

Man quay.io 502 Bad Gateway continues to be a big downer in CI

@cgwalters
Copy link
Collaborator Author

cgwalters commented May 2, 2025

./tmt-test-wrapper-inner.sh-tmt-tests-test-21-logically-bound-switch-2-default-0-default-0: line 1: nu: command not found

Hmmmm....this is really concerning. I wonder if it's the same bug @jmarrero is seeing.

@henrywang
Copy link
Collaborator

henrywang commented May 2, 2025 •
edited
Loading

It's not the nu issue, but a bootc-install-provision timeout. That needs a re-run.

All green now.

@cgwalters cgwalters merged commit 81f6242 into bootc-dev:main May 2, 2025
31 checks passed
@cgwalters
Copy link
Collaborator Author

cgwalters commented May 2, 2025

It's not the nu issue, but a bootc-install-provision timeout. That needs a re-run.

I don't quite understand how a timeout could lead to "command not found" but I will take your word for it!

@henrywang
Copy link
Collaborator

henrywang commented May 3, 2025

The timeout was happened in bootc-install-provision and before nu installation. So the nu was not installed due to timeout. That caused the test failure.
There should be a setting in TMT to do not run the rest of tests if previous one timeout. That setting can avoid confused.

@jmarrero jmarrero mentioned this pull request May 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmarrero jmarrero jmarrero approved these changes

Assignees

No one assigned

Labels

area/install Issues related to `bootc install`

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Err: EvalSymlinks: too many links when using skopeo to pull images

3 participants

@cgwalters @henrywang @jmarrero