reinstall: Pass RUST_LOG env var into bootc install container #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables the bootc install container to receive the host’s RUST_LOG environment variable so that trace logging is available during installation.
- A conditional block is added in podman.rs that checks for the RUST_LOG variable.
- If set, the environment variable is passed into the podman command arguments.
github-actions
bot
added
the
area/system-reinstall-bootc
cgwalters
approved these changes
May 5, 2025
system-reinstall-bootc/src/podman.rs
Outdated
Comment on lines
37
to
38
| podman_command_and_args.push("-e".to_string()); | ||
| podman_command_and_args.push(format!("RUST_LOG={rust_log}")); |
Collaborator
There was a problem hiding this comment.
Minorest-of-minor nits but this would be shorter to read and simpler as
podman_command_and_args.push(format!("--env=RUST_LOG={rust_log}"));
This enables `RUST_LOG=trace system-reinstall-bootc <image>` to print trace messages for the bootc install invocation. Signed-off-by: ckyrouac <[email protected]>
ckyrouac
force-pushed
the
reinstall-rust-log
branch
from
328b4ba to
577f29c
Compare
Collaborator
|
Related to this but I wonder if s-r-b should gain e.g. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables
RUST_LOG=trace system-reinstall-bootc <image>to print trace messages for the bootc install invocation.