Two minor patches #1366
Merged
Two minor patches #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to meke it easier to find. Signed-off-by: Colin Walters <[email protected]>
Minor optimization for previous commit. Signed-off-by: Colin Walters <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| fn write_parents_of( | ||
| &mut self, | ||
| path: &Utf8Path, | ||
| root: &gio::File, |
Contributor
There was a problem hiding this comment.
Passing the root object here allows the function to resolve paths relative to the commit, avoiding redundant loading of the commit object in each recursive call.
Comment on lines
657
to
+658
|
|
||
| self.write_parents_of(parent, cache)?; | ||
| self.write_parents_of(parent, root, cache)?; |
Contributor
There was a problem hiding this comment.
By passing the root, you've ensured that each recursive call uses the same root file, preventing redundant loads.
Comment on lines
+733
to
+736
| let root = writer | ||
| .repo | ||
| .read_commit(&writer.commit_checksum, gio::Cancellable::NONE)? | ||
| .0; |
Contributor
There was a problem hiding this comment.
Moving the read_commit call here ensures that it's only called once per chunk, which reduces the number of calls to the repository.
jeckersb
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-sys: Add a link to rpm-ostree issue
Just to meke it easier to find.
Signed-off-by: Colin Walters [email protected]
tar/export: Only load root once
Minor optimization for previous commit.