-
Notifications
You must be signed in to change notification settings - Fork 129
Bump composefs-fs #1503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump composefs-fs #1503
Conversation
Signed-off-by: Johan-Liebert1 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the composefs-rs
dependency to a newer revision. The changes are straightforward, including updates to Cargo.lock
and Cargo.toml
, and a necessary adaptation in the source code to match the updated API of the dependency. The changes look correct. I have one suggestion to improve the maintainability of the dependency specification in Cargo.toml
.
Error from the Centos-stream-10 CI jobs is a RPM dependency issue in the build:
The Fedora job failures are definitely unrelated to this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the change itself doesn't cause any issues. I don't see how the RPM dependency issue or the image pull could be related to this.
@@ -245,7 +245,8 @@ where | |||
println!("{}", image_id.to_id()); | |||
} | |||
OciCommand::Pull { ref image, name } => { | |||
let (sha256, verity) = composefs_oci::pull(&repo, image, name.as_deref()).await?; | |||
let (sha256, verity) = | |||
composefs_oci::pull(&repo, image, name.as_deref(), None).await?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signature changes because of the new param added to pull()
here, by this commit:
containers/composefs-rs@1a08a28#diff-202658a04902f3f6a4578fa63cf9f6111413c5acfbcccd556631a9a2135dd3ffR65
Makes sense.
I don't see anything specific in the spec file that would be a problem with this repo specifically? Possibly needs a |
Ah, it's mentioned here too: So it's a known issue and being resolved by the looks of it. |
No description provided.