fix(blockdev): include "internals" when spawning loopback-cleanup-helper #1511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug where the loopback-cleanup-helper was being spawned with an incorrect command. By adding the missing internals subcommand, the helper process can now be invoked as intended, ensuring loop devices are properly cleaned up. The change is straightforward, well-contained, and effectively resolves the issue described. The implementation is clean and I have no further suggestions.
Without the "internals" prefix, bootc fails to spawn the loopback-cleanup-helper because the helper is only available under the `bootc internals` subcommand. This patch updates the spawned command to include "internals" before the helper name so it runs as intended. Signed-off-by: Sam Dasilva <[email protected]>
SamD2021
force-pushed
the
fix/blockdev-loopback-cleanup-helper
branch
from
04fa93e to
2e81362
Compare
cgwalters
approved these changes
Aug 14, 2025
Collaborator
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Ouch. Thanks for finding and fixing this.
Contributor
Author
|
Glad to help! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing
internalssubcommand when spawningloopback-cleanup-helperso it runs as intended duringbootc install --via-loopback. Withoutinternals, the helper fails withunrecognized subcommand 'loopback-cleanup-helper', preventing loop device cleanup. This doesn’t block install/boot because the helper is fire-and-forget, but it leaves loop devices uncleared.Fixes: #1510