Map grub feature to composefs-backend and import parser/bls #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request prepares for merging the composefs-backend feature by renaming the grub feature and importing a new BLS parser. The new parser is well-tested, but I have a couple of suggestions to improve its correctness and adherence to the BLS specification. Specifically, the PartialEq implementation for BLSConfig seems incorrect, and the sorting logic deviates from the specification.
cgwalters
force-pushed
the
drop-grub-feature
branch
from
2feb86f to
43f7246
Compare
Collaborator
Author
|
There's definitely more to do for bls, in particular we actually need to handle filenames too. |
This should make it easier to incrementally merge changes here to main. Signed-off-by: Colin Walters <[email protected]>
Signed-off-by: Johan-Liebert1 <[email protected]> Signed-off-by: Colin Walters <[email protected]>
- Handle multiple initrd entries. - Add support for machine-id and sort-key. To do this we can't just map the keys into JSON because we need to handle multiple values. Switch to a manual parser. Assisted-by: Gemini CLI+gemini-2.5-pro Signed-off-by: Colin Walters <[email protected]>
Default string comparisons are wrong for this. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
drop-grub-feature
branch
from
17c03f7 to
7018168
Compare
jeckersb
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some prep work for merging the composefs-backend branch.