Skip to content

Conversation

jeckersb
Copy link
Collaborator

This is a 1-for-1 copy of https://github.com/containers/composefs-rs/pull/143/files, re: #1498 (comment) I'm posting this here as a draft so we have somewhere to add public comments so we can discuss where this needs to change.

@bootc-bot bootc-bot bot requested a review from ckyrouac August 19, 2025 18:15
Copy link
Contributor

@p5 p5 Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to start with a quay.io/fedora/fedora image? Or can we remove the ostree "bits" from the image within the Containerfile so we're certain it's not being relied on (e.g. /ostree)?

Or maybe longer term, there will be a separate Fedora image dedicated for bootc with cfs?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping /ostree is tracked at https://gitlab.com/fedora/bootc/base-images/-/issues/58

That said though note today the https://docs.fedoraproject.org/en-US/bootc/building-from-scratch/ already produces images without it, but that flow has the downside of producing a single large layer, which leads to coreos/rpm-ostree#5383

@Johan-Liebert1
Copy link
Collaborator

Instead of two containerfiles, we can have a two stage build in a single Containerfile; similar to what the UKI build examples in composefs-rs does

mkdir -p tmp/efi
./cfsctl --repo tmp/sysroot/composefs oci pull containers-storage:"${IMAGE_ID}"
./cfsctl --repo tmp/sysroot/composefs oci compute-id --bootable "${IMAGE_ID}"
./cfsctl --repo tmp/sysroot/composefs oci prepare-boot "${IMAGE_ID}" --bootdir tmp/efi
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These use IMAGE_ID from above but (if I'm following correctly) we should re-compute IMAGE_ID based on tmp/iid2 above and use that instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The verity for both iid1 and iid2 should be identical, as they both (essentially) have the same contents. The only difference is that in the second step, we build the UKI and put it inside /boot which is ignored by composefs-rs while creating the EROFS image.

Actually, building the UKI might introduce some artifacts which we do not want to take into account

@Johan-Liebert1 Johan-Liebert1 force-pushed the composefs-backend branch 2 times, most recently from 67c4e8d to b45ef30 Compare August 29, 2025 11:37
travier and others added 4 commits September 3, 2025 17:06
Update bootc examples to use the new unified bootc command interface:
- Replace cfsctl binary with bootc and use 'bootc internals cfs' subcommands
- Rename composefs-setup-root to bootc-initramfs-setup
- Update dracut module from 37composefs to 37bootc
- Remove sudo requirement from podman build commands
- Update service and module configuration files accordingly

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@jeckersb
Copy link
Collaborator Author

jeckersb commented Sep 3, 2025

both the bls and uki examples build successfully now, next item is to wire in tests to ensure these continue building properly in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants