-
Notifications
You must be signed in to change notification settings - Fork 131
examples: Add bootc UKI & BLS examples #1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: composefs-backend
Are you sure you want to change the base?
Conversation
examples/bootc-bls/Containerfile
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to start with a quay.io/fedora/fedora image? Or can we remove the ostree "bits" from the image within the Containerfile so we're certain it's not being relied on (e.g. /ostree
)?
Or maybe longer term, there will be a separate Fedora image dedicated for bootc with cfs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropping /ostree
is tracked at https://gitlab.com/fedora/bootc/base-images/-/issues/58
That said though note today the https://docs.fedoraproject.org/en-US/bootc/building-from-scratch/ already produces images without it, but that flow has the downside of producing a single large layer, which leads to coreos/rpm-ostree#5383
Instead of two containerfiles, we can have a two stage build in a single Containerfile; similar to what the UKI build examples in |
examples/bootc-uki/build.final
Outdated
mkdir -p tmp/efi | ||
./cfsctl --repo tmp/sysroot/composefs oci pull containers-storage:"${IMAGE_ID}" | ||
./cfsctl --repo tmp/sysroot/composefs oci compute-id --bootable "${IMAGE_ID}" | ||
./cfsctl --repo tmp/sysroot/composefs oci prepare-boot "${IMAGE_ID}" --bootdir tmp/efi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These use IMAGE_ID
from above but (if I'm following correctly) we should re-compute IMAGE_ID
based on tmp/iid2
above and use that instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The verity for both iid1
and iid2
should be identical, as they both (essentially) have the same contents. The only difference is that in the second step, we build the UKI and put it inside /boot
which is ignored by composefs-rs
while creating the EROFS image.
Actually, building the UKI might introduce some artifacts which we do not want to take into account
54e254c
to
f10ec34
Compare
67c4e8d
to
b45ef30
Compare
c9aeee5
to
b552c6e
Compare
fd703ec
to
023be10
Compare
Signed-off-by: Timothée Ravier <[email protected]>
Signed-off-by: Timothée Ravier <[email protected]>
Signed-off-by: Timothée Ravier <[email protected]>
Update bootc examples to use the new unified bootc command interface: - Replace cfsctl binary with bootc and use 'bootc internals cfs' subcommands - Rename composefs-setup-root to bootc-initramfs-setup - Update dracut module from 37composefs to 37bootc - Remove sudo requirement from podman build commands - Update service and module configuration files accordingly 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
b552c6e
to
07d7791
Compare
both the bls and uki examples build successfully now, next item is to wire in tests to ensure these continue building properly in CI |
This is a 1-for-1 copy of https://github.com/containers/composefs-rs/pull/143/files, re: #1498 (comment) I'm posting this here as a draft so we have somewhere to add public comments so we can discuss where this needs to change.