kernel_cmdline: remove cfg(test) for require_value_* methods
#1555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeckersb
force-pushed
the
untest-require_value
branch
from
d7a9149 to
f83c655
Compare
jeckersb
changed the title
cfg(test) for require_value_* methods`cfg(test) for require_value_* methods
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request makes the require_value_of and require_value_of_utf8 methods public by removing their #[cfg(test)] attributes. The change is correct and achieves its goal. My review includes suggestions to improve these newly-public functions by making their error handling more specific and enhancing their documentation. Since the functions are now part of the crate's public API, these improvements would increase robustness and usability for consumers.
cgwalters
approved these changes
Aug 27, 2025
This appears to have been accidentally added somewhere along the way, and I would like to use these in composefs-boot. Also fixes duplicate docstring copy/paste error on `require_value_of_utf8`. Signed-off-by: John Eckersberg <[email protected]>
jeckersb
force-pushed
the
untest-require_value
branch
from
f83c655 to
04860d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to have been accidentally added somewhere along the way,
and I would like to use these in composefs-boot.
Signed-off-by: John Eckersberg [email protected]