composefs/install/bls: Fix empty version in config #1558
Conversation
Johan-Liebert1
force-pushed
the
bls-version-fix
branch
from
de82ca6 to
f96ae7e
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where the version field in generated BLS configuration files could be empty. It now correctly populates this field by reading the version from /usr/lib/os-release within the composefs image, with a fallback to a default value. The changes involve plumbing the FileSystem object to where it's needed and introducing a builder pattern for BLSConfig for cleaner construction. The changes look good and address the issue. I have one suggestion to improve consistency in comments and log messages.
Johan-Liebert1
force-pushed
the
bls-version-fix
branch
from
f96ae7e to
f0a336f
Compare
jeckersb
force-pushed
the
composefs-backend
branch
from
54e254c to
f10ec34
Compare
Johan-Liebert1
force-pushed
the
bls-version-fix
branch
from
f0a336f to
43d3b7b
Compare
Johan-Liebert1
force-pushed
the
composefs-backend
branch
from
f10ec34 to
67c4e8d
Compare
Johan-Liebert1
force-pushed
the
bls-version-fix
branch
from
43d3b7b to
606c66d
Compare
Johan-Liebert1
force-pushed
the
composefs-backend
branch
from
67c4e8d to
b45ef30
Compare
Fill `version` field in generated BLS config Signed-off-by: Johan-Liebert1 <[email protected]>
Johan-Liebert1
force-pushed
the
bls-version-fix
branch
from
606c66d to
a8313cb
Compare
| let (id, verity) = initialize_composefs_repository(state, rootfs).await?; | ||
|
|
||
| tracing::warn!( | ||
| tracing::info!( |
There was a problem hiding this comment.
Unrelated but shouldn't this actually be debug!?
There was a problem hiding this comment.
I think we had a discussion some time ago that we want this to show up, but I might be misremembering. Either (info/debug) is fine with me
2 participants
Fill
versionfield in generated BLS config