composefs-native/boot: Handle systemd-boot and grub #1571
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for both systemd-boot and grub by adding a --bootloader option, which is a great enhancement. The changes are well-structured, particularly the use of the BLSEntryPath struct to handle bootloader-specific paths. I've identified a critical issue with temporary directory handling that could lead to resource leaks, and a high-severity issue regarding backward compatibility for existing deployments. Addressing these will make the implementation more robust.
Johan-Liebert1
force-pushed
the
grub-bls-fix
branch
from
f0e8700 to
6362c43
Compare
jeckersb
force-pushed
the
composefs-backend
branch
from
fd703ec to
023be10
Compare
Johan-Liebert1
force-pushed
the
grub-bls-fix
branch
2 times, most recently
from
0838456 to
fa58def
Compare
Fix Grub boot error caused by bootc-dev#1541. Introduce a `--bootloader` cli option to `--composefs-native`. Depending upon the type of bootloader passed in we write BLS configs respectively Signed-off-by: Pragyan Poudyal <[email protected]> Add guard again tempdir drop Signed-off-by: Pragyan Poudyal <[email protected]>
Johan-Liebert1
force-pushed
the
grub-bls-fix
branch
from
fa58def to
31934ae
Compare
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
LGTM as is however...I still think we should detect grub instead via looking for its config files
Is there some peculiar reason why we should be looking for grub config files? I think the EFI vars approach is a bit better as it also lets us distinguish BIOS/UEFI |
In theory we should work with any bootloader that implements the spec instead of specifically detecting systemd-boot - right? |
|
Right. AFAIK bootloaders on UEFI will populate the LoaderInfo file with the bootloader name, which we check right now. Though, we do default to Grub if we can't find |
3 participants
Fix Grub boot error caused by #1541. Introduce a
--bootloadercli option to--composefs-native. Depending upon the type of bootloader passed in we write BLS configs respectively