Un-hide soft-reboot #1580
Merged
Un-hide soft-reboot #1580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We debugged ostreedev/ostree#3503 and it's basically a systemd/Anaconda bug. So we can consider soft reboots an available feature from our end (as systemd does), but certainly one that will require integration testing on the OS/distro side. If you're building a system and you don't want to enable soft reboots, just `rm /usr/lib/systemd/system/soft-reboot.target` or so should do the trick. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
unhide-soft
branch
from
e027514 to
849a634
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request un-hides the --soft-reboot command-line option for upgrade, switch, and rollback commands. The changes are straightforward, but there are a few areas for improvement. I've noted some obsolete comments that should be removed for consistency and suggested expanding the new test to cover all affected commands. Overall, a good change to expose this feature.
Contributor
|
This feature is great btw @jmarrero. Really cool: So fast, and I really think this will help me with my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We debugged ostreedev/ostree#3503 and it's basically a systemd/Anaconda bug. So we can consider soft reboots an available feature from our end (as systemd does), but certainly one that will require integration testing on the OS/distro side.
If you're building a system and you don't want to enable soft reboots, just
rm /usr/lib/systemd/system/soft-reboot.targetor so should do the trick.