spec: Provide ostree-ext on rhel9 #1653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This landed downstream in https://gitlab.com/redhat/centos-stream/rpms/bootc/-/commit/3d4f302c504e565f53a65ecbc7bdaa23c25c2316 but some CI flows build from this spec, so do the change here too. Signed-off-by: Colin Walters <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the bootc.spec file to change the condition for enabling the ostree_ext feature. The change disables ostree_ext by default on RHEL 9, aligning this repository with a change made downstream. While the code change itself appears correct, the pull request title, 'spec: Provide ostree-ext on rhel9', is misleading as the change has the opposite effect. It would be clearer if the title reflected that ostree_ext is being disabled for RHEL 9, for example: 'spec: Don't provide ostree-ext on rhel9'. I've also added a suggestion to improve code clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This landed downstream in https://gitlab.com/redhat/centos-stream/rpms/bootc/-/commit/3d4f302c504e565f53a65ecbc7bdaa23c25c2316 but some CI flows build from this spec, so do the change here too.