build-sys: Reinstall fedora-bootc-destructive-cleanup script #1754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When commit cd8fa59 moved unit enablement to a systemd generator, it also removed the installation of the fedora-bootc-destructive-cleanup script from the Makefile. This was unintentional - while the symlink enablement should be handled by the generator, the script itself still needs to be installed. The trap is that because we weren't accurately removing old files from the build, the old version was still there...until the new upstream release. Fix this in two ways: First, continue to install the script on Fedora-like systems as before, but leave unit enablement to the generator as intended. Second, change how we remove prior state to clean out all files from the RPM. (I did look at changing out the build system so we build an RPM in this case which would be cleaner, but it's a large change) Fixes: bootc-dev#1748 Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly reinstalls the fedora-bootc-destructive-cleanup script, which was unintentionally removed in a previous change. It also improves the cleanup logic in the Dockerfile to be more robust. My review includes two suggestions to further improve the shell scripting used in these changes for better robustness and portability.
ckyrouac
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When commit cd8fa59 moved unit enablement to a systemd generator, it also removed the installation of the fedora-bootc-destructive-cleanup script from the Makefile. This was unintentional - while the symlink enablement should be handled by the generator, the script itself still needs to be installed.
The trap is that because we weren't accurately removing old files from the build, the old version was still there...until the new upstream release.
Fix this in two ways:
First, continue to install the script on Fedora-like systems as before, but leave unit enablement to the generator as intended.
Second, change how we remove prior state to clean out all files from the RPM. (I did look at changing out the build system so we build an RPM in this case which would be cleaner, but it's a large change)
Fixes: #1748
Assisted-by: Claude Code (Sonnet 4.5)