Skip to content

Conversation

@henrywang
Copy link
Collaborator

This PR is to debug system-reinstall-bootc test failure and fix it.

@bootc-bot bootc-bot bot requested a review from gursewak1997 November 12, 2025 08:08
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to debug and fix a test failure in system-reinstall-bootc. The change involves adding a check for the existence of the usr/lib directory and reordering the list of files to be checked in the test. My review focuses on improving the maintainability of this list. I've suggested sorting the file paths alphabetically for better readability and pointed out that the check for usr/lib might be redundant.

Comment on lines 96 to 101
let files = [
"usr/lib/bootc/fedora-bootc-destructive-cleanup",
"usr/lib",
"usr/lib/systemd/system/bootc-destructive-cleanup.service",
"etc/tmpfiles.d/bootc-root-ssh.conf",
"usr/lib/bootc/fedora-bootc-destructive-cleanup",
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved readability and maintainability, consider sorting this list of paths alphabetically.

Also, the check for "usr/lib" appears to be redundant since other paths in the list are located within it. If those checks pass, usr/lib is guaranteed to exist. If this was added for debugging, you may want to remove it.

Suggested change
let files = [
"usr/lib/bootc/fedora-bootc-destructive-cleanup",
"usr/lib",
"usr/lib/systemd/system/bootc-destructive-cleanup.service",
"etc/tmpfiles.d/bootc-root-ssh.conf",
"usr/lib/bootc/fedora-bootc-destructive-cleanup",
];
let files = [
"etc/tmpfiles.d/bootc-root-ssh.conf",
"usr/lib",
"usr/lib/bootc/fedora-bootc-destructive-cleanup",
"usr/lib/systemd/system/bootc-destructive-cleanup.service",
];

@henrywang
Copy link
Collaborator Author

According to result https://github.com/bootc-dev/bootc/actions/runs/19290621315/job/55160247510?pr=1756, this failure looks like a flaky. Re-run all failed tests in PRs and see what happens.

@henrywang
Copy link
Collaborator Author

Test passed in #1746. Close this PR.

@henrywang henrywang closed this Nov 12, 2025
@henrywang henrywang deleted the debug_failure branch November 12, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant