Fix var-tmpfiles lint to check /etc/tmpfiles.d in addition to /usr/lib/tmpfiles.d #1763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the tmpfiles.d parsing logic to support reading configurations from both /usr/lib/tmpfiles.d and /etc/tmpfiles.d, with the latter taking precedence. The changes are well-structured, introducing a helper function read_tmpfiles_from_dir to improve modularity. The core logic for handling precedence is correct. My review includes suggestions to enhance the test suite to more thoroughly cover the new functionality, including testing the precedence logic and ensuring the integration test fully validates the behavior of excluding paths defined in /etc/tmpfiles.d.
gursewak1997
force-pushed
the
fix-tmpfiles-etc-check
branch
5 times, most recently
from
111c3b3 to
eb7fb83
Compare
The bootc container lint command now reads tmpfiles.d configuration files from both /usr/lib/tmpfiles.d and /etc/tmpfiles.d, with /etc entries taking precedence (matching systemd's behavior). Fixes bootc-dev#1732 Signed-off-by: gursewak1997 <[email protected]>
gursewak1997
force-pushed
the
fix-tmpfiles-etc-check
branch
from
eb7fb83 to
b62a14e
Compare
cgwalters
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bootc container lint command now reads tmpfiles.d configuration files from both /usr/lib/tmpfiles.d and /etc/tmpfiles.d, with /etc entries taking precedence (matching systemd's behavior).
Fixes #1732