Minor fixes #1811
Merged
Minor fixes #1811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the function `kargs_from_composefs_filesystem` to `compute_new_kargs` as it now has nothing to do with composefs Signed-off-by: Pragyan Poudyal <[email protected]>
github-actions
bot
added
area/install
This was referenced Nov 26, 2025
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request delivers on its promise of minor fixes, primarily through a function rename for better clarity (kargs_from_composefs_filesystem to compute_new_kargs) and a host of typo corrections across documentation, comments, and log messages. The function rename is accompanied by a much-improved docstring that clearly explains its purpose and parameters. The various typo fixes enhance the overall readability and professionalism of the codebase. All changes are correct and contribute positively to code quality. The pull request is well-executed and ready to be merged.
Fix a few typos across the project. Also update some comments/error messages Signed-off-by: Pragyan Poudyal <[email protected]>
Johan-Liebert1
force-pushed
the
minor-fixes
branch
from
bbc7a5e to
49787ad
Compare
cgwalters
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the function
kargs_from_composefs_filesystemtocompute_new_kargsas it now has nothing to do with composefsFix a few typos across the project. Also update some comments/error
messages